Skip to content

Fix the following CAS-related tests with LLVM_ENABLE_ONDISK_CAS=ON on Windows #11194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

Fix the following CAS-related tests with LLVM_ENABLE_ONDISK_CAS=ON on Windows #11194

merged 1 commit into from
Aug 19, 2025

Conversation

@hjyamauchi
Copy link

@hjyamauchi hjyamauchi commented Aug 18, 2025

Fix the following CAS-related tests with LLVM_ENABLE_ONDISK_CAS=ON on Windows

Clang :: ClangScanDeps/include-tree-multiple-commands.c
Clang :: ClangScanDeps/include-tree-pragma-system-header.c
Clang :: ClangScanDeps/include-tree-preserve-pch-path.c
Clang :: ClangScanDeps/modules-include-tree-api-notes.c
Clang :: ClangScanDeps/modules-include-tree-by-mod-name.c
Clang :: ClangScanDeps/modules-include-tree-dependency-file.c
Clang :: ClangScanDeps/modules-include-tree-diag-opts.c
Clang :: ClangScanDeps/modules-include-tree-export-as.c
Clang :: ClangScanDeps/modules-include-tree-exports.c
Clang :: ClangScanDeps/modules-include-tree-has-include-umbrella-header.c
Clang :: ClangScanDeps/modules-include-tree-implementation-private.c
Clang :: ClangScanDeps/modules-include-tree-implementation-transitive.c
Clang :: ClangScanDeps/modules-include-tree-implementation-via-spurious.c
Clang :: ClangScanDeps/modules-include-tree-pch-common-stale.c
Clang :: ClangScanDeps/modules-include-tree-sdk-settings.c
Clang :: ClangScanDeps/modules-include-tree-vfsoverlay.c
Clang :: ClangScanDeps/optimize-vfs-pch-tree.m
Clang-Unit :: ./AllClangUnitTests.exe/8/48 DependencyScanningCASFilesystem.FilenameSpelling
Clang-Unit :: ./AllClangUnitTests.exe/9/48 DependencyScanningCASFilesystem.DirectiveScanFailure
LLVM-Unit :: CAS/./CASTests.exe/19/38 InMemoryCAS/CASTest.ActionCacheAsync
LLVM-Unit :: CAS/./CASTests.exe/30/38 OnDiskCAS/CASTest.ActionCacheAsync
LLVM-Unit :: CAS/./CASTests.exe/CASConfigurationTest/configFileSearch
LLVM-Unit :: CAS/./CASTests.exe/OnDiskCASLoggerTest/MultiProcess
LLVM-Unit :: CAS/./CASTests.exe/OnDiskCASTest/BlobsBigParallelMultiCAS
LLVM-Unit :: CAS/./CASTests.exe/OnDiskCASTest/BlobsParallelMultiCAS
LLVM-Unit :: CAS/./CASTests.exe/PluginCASTest/isMaterialized

@hjyamauchi
Copy link
Author

hjyamauchi commented Aug 18, 2025

@swift-ci please test llvm

@hjyamauchi
Copy link
Author

hjyamauchi commented Aug 18, 2025

@swift-ci please test llvm

@hjyamauchi
Copy link
Author

hjyamauchi commented Aug 18, 2025

@swift-ci please test llvm for Linux

@hjyamauchi
Copy link
Author

hjyamauchi commented Aug 18, 2025

@swift-ci please test llvm Linux platform

@hjyamauchi
Copy link
Author

hjyamauchi commented Aug 18, 2025

@swift-ci please test llvm

@hjyamauchi
Copy link
Author

hjyamauchi commented Aug 18, 2025

@swift-ci please test llvm Linux platform

@hjyamauchi
Copy link
Author

hjyamauchi commented Aug 18, 2025

@swift-ci please clean test llvm

@hjyamauchi
Copy link
Author

hjyamauchi commented Aug 18, 2025

@swift-ci please test llvm

@hjyamauchi
Copy link
Author

hjyamauchi commented Aug 18, 2025

I think these tests are currently broken at head

Failed Tests (17):
Clang :: Index/Store/record-hash-using.cpp
Clang :: Refactor/FillInEnumSwitchCases/fill-in-cases-forward-decl.c
Clang :: Refactor/FillInEnumSwitchCases/fill-in-cases-opaque-decl.cpp
Clang :: Refactor/ImplementDeclaredMethods/implement-declared-methods.cpp
Clang :: Refactor/Rename/CanonicalizeInstantiatedDecls.cpp
Clang :: Refactor/Rename/ClassAsTemplateArgument.cpp
Clang :: Refactor/Rename/ClassSimpleRenaming.cpp
Clang :: Refactor/Rename/ComplicatedClassType.cpp
Clang :: Refactor/Rename/Ctor.cpp
Clang :: Refactor/Rename/MultiFileTU.cpp
Clang :: Refactor/Rename/ProhibitedDeclarations.cpp
Clang :: Refactor/Rename/TransparentTypedef.m
Clang :: Refactor/Rename/TypedefTag.cpp
Clang :: Refactor/Rename/UserDefinedConversion.cpp
Clang :: Refactor/Rename/UsingDecl.cpp
Clang :: Refactor/Rename/rename-initiate-usr.cpp
Clang :: Refactor/Rename/rename-initiate.cpp

@hjyamauchi hjyamauchi marked this pull request as ready for review August 18, 2025 22:02
cachemeifyoucan
cachemeifyoucan reviewed Aug 18, 2025
View reviewed changes
Copy link

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@hjyamauchi
Copy link
Author

hjyamauchi commented Aug 19, 2025

@swift-ci please test llvm

@hjyamauchi
Copy link
Author

hjyamauchi commented Aug 19, 2025 •
edited
Loading

There seems to be an unrelated build error on Linux

[2025-08-19T17:56:54.127Z] FAILED: [code=1] lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/MachineSMEABIPass.cpp.o 
[2025-08-19T17:56:54.127Z] /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/build-user/llvm-project/build/lib/Target/AArch64 -I/home/build-user/llvm-project/llvm/lib/Target/AArch64 -I/home/build-user/llvm-project/build/include -I/home/build-user/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -fvisibility=hidden  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/MachineSMEABIPass.cpp.o -MF lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/MachineSMEABIPass.cpp.o.d -o lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/MachineSMEABIPass.cpp.o -c /home/build-user/llvm-project/llvm/lib/Target/AArch64/MachineSMEABIPass.cpp
[2025-08-19T17:56:54.127Z] /home/build-user/llvm-project/llvm/lib/Target/AArch64/MachineSMEABIPass.cpp:255: error: declaration of 'llvm::EdgeBundles* {anonymous}::MachineSMEABI::EdgeBundles' changes meaning of 'EdgeBundles' [-fpermissive]
[2025-08-19T17:56:54.127Z]   255 |   EdgeBundles *EdgeBundles = nullptr;
[2025-08-19T17:56:54.127Z]       | 
[2025-08-19T17:56:54.127Z] In file included from /home/build-user/llvm-project/llvm/lib/Target/AArch64/MachineSMEABIPass.cpp:62:
[2025-08-19T17:56:54.127Z] /home/build-user/llvm-project/llvm/include/llvm/CodeGen/EdgeBundles.h:27: note: 'EdgeBundles' declared here as 'class llvm::EdgeBundles'
[2025-08-19T17:56:54.127Z]    27 | class EdgeBundles {
[2025-08-19T17:56:54.127Z]       |

@hjyamauchi
Copy link
Author

hjyamauchi commented Aug 19, 2025

@swift-ci please test llvm

@hjyamauchi
Copy link
Author

hjyamauchi commented Aug 19, 2025

Also there are test failures on mac

[2025-08-19T20:09:16.238Z] Failed Tests (22):
[2025-08-19T20:09:16.238Z]   Clang :: BoundsSafety/CodeGen/compound-literal-counted_by_or_null-O2.c
[2025-08-19T20:09:16.238Z]   Clang :: BoundsSafety/CodeGen/compound-literal-sized_by_or_null-O2.c
[2025-08-19T20:09:16.238Z]   Clang :: BoundsSafety/CodeGen/init-struct-const-count-O2.c
[2025-08-19T20:09:16.238Z]   Clang :: Index/Store/record-hash-using.cpp
[2025-08-19T20:09:16.238Z]   Clang :: Refactor/FillInEnumSwitchCases/fill-in-cases-forward-decl.c
[2025-08-19T20:09:16.238Z]   Clang :: Refactor/FillInEnumSwitchCases/fill-in-cases-opaque-decl.cpp
[2025-08-19T20:09:16.239Z]   Clang :: Refactor/ImplementDeclaredMethods/implement-declared-methods.cpp
[2025-08-19T20:09:16.239Z]   Clang :: Refactor/Rename/CanonicalizeInstantiatedDecls.cpp
[2025-08-19T20:09:16.239Z]   Clang :: Refactor/Rename/ClassAsTemplateArgument.cpp
[2025-08-19T20:09:16.239Z]   Clang :: Refactor/Rename/ClassSimpleRenaming.cpp
[2025-08-19T20:09:16.239Z]   Clang :: Refactor/Rename/ComplicatedClassType.cpp
[2025-08-19T20:09:16.239Z]   Clang :: Refactor/Rename/Ctor.cpp
[2025-08-19T20:09:16.239Z]   Clang :: Refactor/Rename/MultiFileTU.cpp
[2025-08-19T20:09:16.239Z]   Clang :: Refactor/Rename/ProhibitedDeclarations.cpp
[2025-08-19T20:09:16.239Z]   Clang :: Refactor/Rename/TransparentTypedef.m
[2025-08-19T20:09:16.239Z]   Clang :: Refactor/Rename/TypedefTag.cpp
[2025-08-19T20:09:16.239Z]   Clang :: Refactor/Rename/UserDefinedConversion.cpp
[2025-08-19T20:09:16.239Z]   Clang :: Refactor/Rename/UsingDecl.cpp
[2025-08-19T20:09:16.239Z]   Clang :: Refactor/Rename/rename-initiate-usr.cpp
[2025-08-19T20:09:16.239Z]   Clang :: Refactor/Rename/rename-initiate.cpp
[2025-08-19T20:09:16.239Z]   Clang :: Sema/ptrauth-qualifier.c
[2025-08-19T20:09:16.239Z]   Clang :: SemaObjC/ptrauth-qualifier.m

@hjyamauchi
Fix the following CAS-related tests with LLVM_ENABLE_ONDISK_CAS=ON on…
3565e38 
… Windows

Clang :: ClangScanDeps/include-tree-multiple-commands.c
Clang :: ClangScanDeps/include-tree-pragma-system-header.c
Clang :: ClangScanDeps/include-tree-preserve-pch-path.c
Clang :: ClangScanDeps/modules-include-tree-api-notes.c
Clang :: ClangScanDeps/modules-include-tree-by-mod-name.c
Clang :: ClangScanDeps/modules-include-tree-dependency-file.c
Clang :: ClangScanDeps/modules-include-tree-diag-opts.c
Clang :: ClangScanDeps/modules-include-tree-export-as.c
Clang :: ClangScanDeps/modules-include-tree-exports.c
Clang :: ClangScanDeps/modules-include-tree-has-include-umbrella-header.c
Clang :: ClangScanDeps/modules-include-tree-implementation-private.c
Clang :: ClangScanDeps/modules-include-tree-implementation-transitive.c
Clang :: ClangScanDeps/modules-include-tree-implementation-via-spurious.c
Clang :: ClangScanDeps/modules-include-tree-pch-common-stale.c
Clang :: ClangScanDeps/modules-include-tree-sdk-settings.c
Clang :: ClangScanDeps/modules-include-tree-vfsoverlay.c
Clang :: ClangScanDeps/optimize-vfs-pch-tree.m
Clang-Unit :: ./AllClangUnitTests.exe/8/48 DependencyScanningCASFilesystem.FilenameSpelling
Clang-Unit :: ./AllClangUnitTests.exe/9/48 DependencyScanningCASFilesystem.DirectiveScanFailure
LLVM-Unit :: CAS/./CASTests.exe/19/38 InMemoryCAS/CASTest.ActionCacheAsync
LLVM-Unit :: CAS/./CASTests.exe/30/38 OnDiskCAS/CASTest.ActionCacheAsync
LLVM-Unit :: CAS/./CASTests.exe/CASConfigurationTest/configFileSearch
LLVM-Unit :: CAS/./CASTests.exe/OnDiskCASLoggerTest/MultiProcess
LLVM-Unit :: CAS/./CASTests.exe/OnDiskCASTest/BlobsBigParallelMultiCAS
LLVM-Unit :: CAS/./CASTests.exe/OnDiskCASTest/BlobsParallelMultiCAS
LLVM-Unit :: CAS/./CASTests.exe/PluginCASTest/isMaterialized
@hjyamauchi
Copy link
Author

hjyamauchi commented Aug 19, 2025

@swift-ci please test llvm

@hjyamauchi
Copy link
Author

hjyamauchi commented Aug 19, 2025

The build failure is gone after rebase and the test failures remain.

@hjyamauchi hjyamauchi merged commit ba40553 into swiftlang:next Aug 19, 2025
0 of 2 checks passed
hjyamauchi added a commit that referenced this pull request Oct 9, 2025
@hjyamauchi
Fix the following CAS-related tests with LLVM_ENABLE_ONDISK_CAS=ON on…
b43d666 
… Windows (#11194)

Clang :: ClangScanDeps/include-tree-multiple-commands.c
Clang :: ClangScanDeps/include-tree-pragma-system-header.c
Clang :: ClangScanDeps/include-tree-preserve-pch-path.c
Clang :: ClangScanDeps/modules-include-tree-api-notes.c
Clang :: ClangScanDeps/modules-include-tree-by-mod-name.c
Clang :: ClangScanDeps/modules-include-tree-dependency-file.c
Clang :: ClangScanDeps/modules-include-tree-diag-opts.c
Clang :: ClangScanDeps/modules-include-tree-export-as.c
Clang :: ClangScanDeps/modules-include-tree-exports.c
Clang :: ClangScanDeps/modules-include-tree-has-include-umbrella-header.c
Clang :: ClangScanDeps/modules-include-tree-implementation-private.c
Clang :: ClangScanDeps/modules-include-tree-implementation-transitive.c
Clang :: ClangScanDeps/modules-include-tree-implementation-via-spurious.c
Clang :: ClangScanDeps/modules-include-tree-pch-common-stale.c
Clang :: ClangScanDeps/modules-include-tree-sdk-settings.c
Clang :: ClangScanDeps/modules-include-tree-vfsoverlay.c
Clang :: ClangScanDeps/optimize-vfs-pch-tree.m
Clang-Unit :: ./AllClangUnitTests.exe/8/48 DependencyScanningCASFilesystem.FilenameSpelling
Clang-Unit :: ./AllClangUnitTests.exe/9/48 DependencyScanningCASFilesystem.DirectiveScanFailure
LLVM-Unit :: CAS/./CASTests.exe/19/38 InMemoryCAS/CASTest.ActionCacheAsync
LLVM-Unit :: CAS/./CASTests.exe/30/38 OnDiskCAS/CASTest.ActionCacheAsync
LLVM-Unit :: CAS/./CASTests.exe/CASConfigurationTest/configFileSearch
LLVM-Unit :: CAS/./CASTests.exe/OnDiskCASLoggerTest/MultiProcess
LLVM-Unit :: CAS/./CASTests.exe/OnDiskCASTest/BlobsBigParallelMultiCAS
LLVM-Unit :: CAS/./CASTests.exe/OnDiskCASTest/BlobsParallelMultiCAS
LLVM-Unit :: CAS/./CASTests.exe/PluginCASTest/isMaterialized

(Cherry picked from commit ba40553)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cachemeifyoucan cachemeifyoucan cachemeifyoucan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hjyamauchi @cachemeifyoucan